Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PipelineSpec and TaskSpec fields of PipelineRun and TaskRun Status fields #4891

Merged
merged 1 commit into from
May 31, 2022
Merged

Update PipelineSpec and TaskSpec fields of PipelineRun and TaskRun Status fields #4891

merged 1 commit into from
May 31, 2022

Commits on May 26, 2022

  1. Update PipelineSpec and TaskSpec fields of PipelineRun and TaskRun St… 

    …atus fields

`PipelineSpec` was only stored in the `PipelineRun` `Status` field [once](https://github.com/tektoncd/pipeline/blob/6f633b2a41455c6d7cad12d51243b2d1a8716544/pkg/reconciler/pipelinerun/pipelinerun.go#L358), before any substitutions. The same thing was happening with the `TaskSpec` field of the `TaskRun's` `Status` (See [here](https://github.com/tektoncd/pipeline/blob/6f633b2a41455c6d7cad12d51243b2d1a8716544/pkg/reconciler/taskrun/taskrun.go#L310)). As a result, after execution of the `pipelinerun` or `taskrun`, the `(task/pipeline)specs` of the `status` fields were not updated leading to confusion.

This commit also updates the `TaskSpec and PipelineSpec` of `Status` fields
of `TaskRun` and `PipelineRun`, respectively, after application of the
substitutions. As a result, the replacements are now visible in the
run status.
    @chitrangpatel
    chitrangpatel committed May 26, 2022
    Configuration menu
    Copy the full SHA
    35e03c0 View commit details
    Browse the repository at this point in the history