-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constant backoff for TaskRun retry #4881
Add constant backoff for TaskRun retry #4881
Conversation
|
Hi @yhil. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Set constant retry backoff when TaskRun Pods not started due to compute resources unavailaibility Issue tektoncd#4847
6caa6c0
to
886408d
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A Taskrun not started due to compute resources unavailability have a exponential retry backoff.
When a Taskrun could not start due to compute resources unavailability for it's pods, it will restart after a few seconds. If it occurs again, the backoff will be increased. After several retries failure, it will take minutes before the TaskRun been started again.
Between two retries, compute resource may be available for the TaskRun Pods and we want them to be started at that time not when backoff is elapsed.
Changes
The PR implement the change proposed by @imjasonh in issue comment #4847
A description of my tests related to the code change in issue comment #4847
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes