-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0090: Refactor execution status validation #4635
Conversation
The following is the coverage report on the affected files.
|
Today, the execution status validation is long and has duplicated code. We need to validate execution status in matrix, a feature proposed in TEP-0090. To set up for that, we are refactoring the execution status validation in this change which includes splitting up the function and reusing common logic.
cbff0f7
to
02f5ce6
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @jerop
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test pull-tekton-pipeline-alpha-integration-tests |
Changes
Today, the execution status validation is long and has duplicated code. We need to validate execution status in matrix, a feature proposed in TEP-0090. To set up for that, we are refactoring the execution status validation in this change which includes splitting up the function and reusing common logic.
cc @pritidesai
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes