-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create codeql-analysis.yml #4591
Conversation
Enable the standard codeql analysis from GitHub.
/test pull-tekton-pipeline-alpha-integration-tests |
@vdemeester @dibyom @bobcatfish This didn't find any issue - only a couple in test code which I dismissed as not relevant. |
Just my 2c - I've never seen this find a relevant issue. It takes a long time and it's only ever noticed 2-3 things for me that weren't valid. I think codeql is better in native non-memory safe code. It's not really that annoying since false positives are rare, but any findings at all are very rare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't take more time than any of our current jobs, so.. I am fine having it there.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Enable the standard codeql analysis from GitHub.
This runs as a GitHub action. The configuration is the vanilla one proposed by GitHub.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes