Add image replacement for amd64 specific image #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the TestExamples/v1beta1/taskruns/entrypoint-resolution test amd64/ubuntu image is used. The test fails for linux/s390x platform, because s390x specific image is required. The fix uses existing replacement logic to replace amd64/ubuntu to s390x/ubuntu for tests, executed on linux/s390x platform Signed-off-by: Yulia Gaponenko <[email protected]>
tekton-robot
added
release-note-none
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
Jan 10, 2022
tekton-robot
added
the
approved
|
/cc @imjasonh |
imjasonh
approved these changes
Jan 10, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imjasonh, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the TestExamples/v1beta1/taskruns/entrypoint-resolution test amd64/ubuntu image is used. The test fails for linux/s390x platform, because s390x specific image is required.
The fix uses existing replacement logic to replace amd64/ubuntu to s390x/ubuntu for tests,
executed on linux/s390x platform.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes