Remove --enable-basic-auth from the development guide
#4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
Today, the development guide uses basic auth and causes errors during set up Basic authentication is deprecated and has been removed in 1.19 and later Given that we require 1.20, we need to remove this flag in development guide Reference: https://cloud.google.com/kubernetes-engine/docs/how-to/api-server-authentication
jerop
force-pushed
the
remove-basic-auth
branch
from
c5ea81e
to
48c9b86
Compare
jerop
changed the title
--enable-basic-auth from development guide--enable-basic-auth from the development guide
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
Jan 5, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Today, the development guide uses basic auth and causes errors during set up
Basic authentication is deprecated and has been removed in 1.19 and later
Given that we require 1.20, we need to remove this flag in development guide
Reference: https://cloud.google.com/kubernetes-engine/docs/how-to/api-server-authentication
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes