test/sidecar_test.go: replace t.Errorfs with t.Fatalfs #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t.Fatalf causes the test to fail and return (or in this case, move on to the next t.Run), while t.Errorf casues the test to fail but keeps going. There's a bunch of dependent logic in this test where if one step fails, we try to access it and nil panic. This change replaces a bunch of Errorfs -> Fatalfs where we rely on these condition assumptions. Cases where we are just examining the result for certain properties are left as Errorf so we can check multiple things before returning out.
tekton-robot
added
release-note
tekton-robot
added
the
size/S
|
/lgtm |
jerop
approved these changes
Dec 21, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
LGTM! thanks for improving tests! |
|
/test pull-tekton-pipeline-alpha-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
t.Fatalf causes the test to fail and return (or in this case, move on to
the next t.Run), while t.Errorf casues the test to fail but keeps going.
There's a bunch of dependent logic in this test where if one step fails,
we try to access it and nil panic.
This change replaces a bunch of Errorfs -> Fatalfs where we rely on these
condition assumptions. Cases where we are just examining the result for
certain properties are left as Errorf so we can check multiple things
before returning out.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes