Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps with lru cache #418

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Update deps with lru cache #418

merged 1 commit into from
Jan 22, 2019

Conversation

afrittoli
Copy link
Member

Missing dep, probably after lru cache was implemented in
#350

@afrittoli
Update deps with lru cache
c6c94bc 
Missing dep, probably after lru cache was implemented in
tektoncd#350
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2019
@afrittoli afrittoli mentioned this pull request Jan 22, 2019
Closed
@vdemeester
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2019
@afrittoli
Copy link
Member Author

I think the failure is caused by the Helm E2E test flakyness #289

@afrittoli
Copy link
Member Author

/test pull-knative-build-pipeline-integration-tests

@bobcatfish
Copy link
Collaborator

whoa, thanks for the fix @afrittoli ! i wonder why our CI didn't catch this one :S

/approve
/lgtm
/meow space

@knative-prow-robot
Copy link

@bobcatfish: cat image

In response to this:

whoa, thanks for the fix @afrittoli ! i wonder why our CI didn't catch this one :S

/approve
/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@bobcatfish bobcatfish mentioned this pull request Jan 22, 2019
Closed
@knative-prow-robot knative-prow-robot merged commit bcd4a14 into tektoncd:master Jan 22, 2019
pradeepitm12 pushed a commit to pradeepitm12/pipeline that referenced this pull request Jan 28, 2021
@piyush-garg @tekton-robot
Delete clusterscoped resource in teardown
7ba80a7 
This will delete the clusterscoped resources we are creating
in event listener e2e tests during teardown

Fix tektoncd#418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @vdemeester @bobcatfish @knative-prow-robot