(cleanup) use skipping reason instead of existence of variables #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
|
/test tekton-pipeline-unit-tests |
tekton-robot
removed
the
do-not-merge/work-in-progress
pritidesai
approved these changes
Aug 12, 2021
tekton-robot
added
the
approved
pritidesai
reviewed
Aug 12, 2021
vdemeester
approved these changes
Aug 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jerop
force-pushed
the
skipped-task-no-variable
branch
from
f0e4efd
to
1d0b71f
Compare
tekton-robot
added
size/L
|
/test tekton-pipeline-unit-tests |
today, we existence of variables to determine whether to add `when` expressions to the skipped `tasks` status for finally tasks (we only add them when they are resolved, have no variables) we recently added skipping reason in tektoncd#4085 now that we have skipping reason, we can use it to check that the reason for skipping is that `when` expressions evaluated to false before including the resolved `when` expressions to the skipped `tasks` status we plan to explore adding skipping reason to the skipped `tasks` status in the future, but for now this change reuses this new functionality
jerop
force-pushed
the
skipped-task-no-variable
branch
from
1d0b71f
to
f48841b
Compare
|
/test pull-tekton-pipeline-go-coverage |
bobcatfish
reviewed
Aug 17, 2021
|
/test pull-tekton-pipeline-alpha-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
today, we use existence of variables to determine whether to add
whenexpressions to the skippedtasksstatus for finally tasks(we only add them when they are resolved, have no variables)
we recently added skipping reason in #4085
now that we have skipping reason, we can use it to check that the reason
for skipping is that
whenexpressions evaluated to false beforeincluding the resolved
whenexpressions to the skippedtasksstatuswe plan to explore adding skipping reason to the skipped
tasksstatusin the future, but for now this change reuses this new functionality
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/cc @pritidesai