Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update releases tasks/pipeline to use workspaces #2897

Closed
wants to merge 1 commit into from
Closed

Update releases tasks/pipeline to use workspaces #2897

wants to merge 1 commit into from

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 3, 2020 •
edited
Loading

Changes

Let's try to use workspaces to do the release instead of relying on
PipelineResource and v1alpha1 golang catalog resources.

This updates the tasks and pipeline to use workspaces.
This also update a little bit the readme with kubectl diff commands
to show what will be applied before applying it.

Signed-off-by: Vincent Demeester [email protected]

Linked to tektoncd/plumbing#456

/kind misc
/area release
/cc @afrittoli
/hold

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Update the tasks and pipelines to use workspaces for the releases

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. area/release Indicates an issue on release (process, tasks). labels Jul 3, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

This was referenced Jul 3, 2020
Closed
Closed
Closed
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2020
@vdemeester
Copy link
Member Author

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this PR.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020
@vdemeester
Update releases tasks/pipeline to use workspaces
318b753 
Let's try to use workspaces to do the release instead of relying on
PipelineResource and v1alpha1 golang catalog resources.

This updates the tasks and pipeline to use workspaces.
This also update a little bit the readme with `kubectl diff` commands
to show what will be applied before applying it.

Signed-off-by: Vincent Demeester <[email protected]>
vdemeester added a commit to vdemeester/tektoncd-pipeline that referenced this pull request Aug 17, 2020
@vdemeester
tekton: migrate release task and pipeline to v1beta1
2b884dc 
This extracts the migration to v1beta1 part from tektoncd#2897. Release tasks
and pipelines from the `tekton/` folder are migrated to use v1beta1 APIs.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester mentioned this pull request Aug 17, 2020
Merged
4 tasks
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2020
@vdemeester
Copy link
Member Author

/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester added a commit to vdemeester/tektoncd-pipeline that referenced this pull request Sep 15, 2020
@vdemeester
tekton: migrate release task and pipeline to v1beta1
5215ca8 
This extracts the migration to v1beta1 part from tektoncd#2897. Release tasks
and pipelines from the `tekton/` folder are migrated to use v1beta1 APIs.

Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot pushed a commit that referenced this pull request Oct 2, 2020
@vdemeester @tekton-robot
tekton: migrate release task and pipeline to v1beta1
fa9dffe 
This extracts the migration to v1beta1 part from #2897. Release tasks
and pipelines from the `tekton/` folder are migrated to use v1beta1 APIs.

Signed-off-by: Vincent Demeester <[email protected]>
AverageMarcus pushed a commit to AverageMarcus/pipeline that referenced this pull request Oct 23, 2020
@vdemeester @AverageMarcus
tekton: migrate release task and pipeline to v1beta1
0d3ef40 
This extracts the migration to v1beta1 part from tektoncd#2897. Release tasks
and pipelines from the `tekton/` folder are migrated to use v1beta1 APIs.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester deleted the release-workspace branch July 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees
No one assigned
Labels
area/release Indicates an issue on release (process, tasks). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdemeester @tekton-robot