Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make verify-codegen.sh also check /vendor #288

Conversation

chaodaiG
Copy link
Contributor

Replicated from: knative/serving#2561

Original link: knative/serving#1711

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2018
@chaodaiG
Copy link
Contributor Author

/cc @adrcunha

@adrcunha
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2018
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@adrcunha
Copy link
Contributor

/retest

2 similar comments
@chaodaiG
Copy link
Contributor Author

/retest

@chaodaiG
Copy link
Contributor Author

/retest

@bobcatfish
Copy link
Collaborator

whoa! the flake is getting out of control (#288)! i wonder why it's worse today 🤔 maybe something new has gone wrong

@vdemeester
Copy link
Member

/test pull-knative-build-pipeline-integration-tests

@adrcunha
Copy link
Contributor

adrcunha commented Dec 3, 2018

/retest

2 similar comments
@adrcunha
Copy link
Contributor

adrcunha commented Dec 3, 2018

/retest

@adrcunha
Copy link
Contributor

adrcunha commented Dec 3, 2018

/retest

@knative-prow-robot knative-prow-robot merged commit 563bfe9 into tektoncd:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants