Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish nightly knative/build-pipeline releases to knative-nightly #284

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Publish nightly knative/build-pipeline releases to knative-nightly #284

merged 2 commits into from
Nov 30, 2018

Conversation

adrcunha
Copy link
Contributor

Part of knative/serving#2555.

Bonus: added documentation about the /hack dir and the release script.

@adrcunha
Publish nightly knative/build-pipeline releases to knative-nightly
b86c91b 
Part of knative/serving#2555.

Bonus: added documentation about the `/hack` dir and the release script.
@adrcunha adrcunha requested a review from imjasonh November 30, 2018 03:04
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2018
@adrcunha adrcunha requested review from bobcatfish and removed request for ericKlawitter and dushyanthsc November 30, 2018 03:09
vdemeester
vdemeester approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bobcatfish
bobcatfish reviewed Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful docs @adrcunha 😍 thanks for adding these!

hack/release.md Outdated Show resolved Hide resolved
hack/release.md Show resolved Hide resolved
@bobcatfish
Copy link
Collaborator

/lgtm
/meow space

@knative-prow-robot
Copy link

@bobcatfish: cat image

In response to this:

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2018
@adrcunha
Copy link
Contributor Author

/retest

@bobcatfish
Copy link
Collaborator

ugh sorry about that @adrcunha , that helm test has flaked out on us a few times, im gonna add an issue to the backlog to de-flake it

@knative-prow-robot knative-prow-robot merged commit 6f4b75c into tektoncd:master Nov 30, 2018
@bobcatfish bobcatfish mentioned this pull request Nov 30, 2018
Closed
@bobcatfish
Copy link
Collaborator

Created #289 about the flakey test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@vdemeester vdemeester vdemeester approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrcunha @knative-prow-robot @bobcatfish @vdemeester