Start emitting CloudEvents for TaskRuns

[afrittoli]

Changes

Add a new method 'SendCloudEventWithRetries' to the cloud events
controller. It that allows emitting cloud events asynchronously
(in a go routine), taking benefit of the retries capabilities of
the cloudevents go sdk.

Rework the fake client to allow for unit testing of
'SendCloudEventWithRetries'. The new implementation is similar
to that of the fake recorder from client-go, which allows to
unit test k8s events and cloud events in a similar fashion.

Add a new config option default-cloud-events-sink in the
defaults config map. This options allows setting a default sink
for cloud events. If the default sink is setup, cloud events are
sent, else they're disabled.

Invoke 'SendCloudEventWithRetries' from the events modules so
that we start sending cloud events in the same places we were
send k8s events (except for errors).

Most of the plumbing is in place to start emitting cloud events
for pipeline runs too, however there is a small refactor for
the config maps required before we can add that, so this commit
only enabled cloud events for task runs for now.

Partially addresses #2082

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Add a new configuration option `default-cloud-events-sink` in the defaults config map.
This options allows setting a default sink for cloud events. 
If the default sink is setup, cloud events are sent, else they're disabled.

Send cloud events (when enabled) from the task run and controller, for all non-error
events that are already notified via k8s events.

/cc @n3wscott
/cc @bobcatfish

/kind feature

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	21.1%	13.9
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/taskrun/taskrun.go	77.6%	77.4%	-0.3

[afrittoli]

WIP because tests are missing for the config map part of the PR - I need to test that the config option is pulled in correctly in the context. It may be worth adding at least one reconciler test.
Adding an E2E test would require a custom config of Tekton for that.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/taskrun/taskrun.go	77.6%	75.9%	-1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/taskrun/taskrun.go	77.6%	75.9%	-1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/taskrun/taskrun.go	77.6%	75.9%	-1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.3%	-2.3
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	26.7%	19.5
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/taskrun/taskrun.go	77.6%	75.8%	-1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	40.9%	-40.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	40.9%	-40.9
pkg/reconciler/pipelinerun/pipelinerun.go	85.9%	85.9%	-0.0
pkg/reconciler/taskrun/taskrun.go	76.5%	76.2%	-0.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	40.9%	-40.9
pkg/reconciler/pipelinerun/pipelinerun.go	86.0%	85.9%	-0.0
pkg/reconciler/taskrun/taskrun.go	76.6%	76.3%	-0.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	40.9%	-40.9
pkg/reconciler/pipelinerun/pipelinerun.go	86.0%	85.9%	-0.0
pkg/reconciler/taskrun/taskrun.go	76.6%	76.3%	-0.3

[afrittoli]

Should add unit tests to events to restore a good coverage. Also need to add cloud event testing to pipelinerun_test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	86.4%	4.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.0%	85.9%	-0.0
pkg/reconciler/taskrun/taskrun.go	76.6%	76.3%	-0.3

[vdemeester]

/meow

[tekton-robot]

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/events/cloudevent/cloud_event_controller.go	94.6%	92.7%	-1.9
pkg/reconciler/events/cloudevent/cloudevent.go	88.2%	90.6%	2.3
pkg/reconciler/events/cloudevent/cloudeventclient.go	7.1%	37.5%	30.4
pkg/reconciler/events/cloudevent/cloudeventsfakeclient.go	50.0%	54.5%	4.5
pkg/reconciler/events/event.go	81.8%	86.4%	4.5
pkg/reconciler/pipelinerun/pipelinerun.go	86.0%	85.9%	-0.0
pkg/reconciler/taskrun/taskrun.go	76.6%	76.3%	-0.3

[khrm]

/lgtm