Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChildReference -> actual object status helper functions aren't handling v1alpha1.Runs. #5933

Closed
abayer opened this issue Jan 3, 2023 · 0 comments · Fixed by #5936
Closed

ChildReference -> actual object status helper functions aren't handling v1alpha1.Runs. #5933

abayer opened this issue Jan 3, 2023 · 0 comments · Fixed by #5936
Assignees
@abayer
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
Pipelines v0.44 (...

Comments

@abayer
Copy link
Contributor

abayer commented Jan 3, 2023

When I added support for CustomRuns to the reconciler, I switched the logic in pkg/status to use CustomRun instead of Run...but we want to support both CustomRuns and Runs, with Runs still the default for now. So we need to add back in support for v1alpha1.Run in the relevant functions.

This should get backported to v0.43.x.

cc @piyush-garg @vinamra28 since this is what's causing the tests in tektoncd/cli#1838 to fail

/kind bug
@abayer abayer added the kind/bug Categorizes issue or PR as related to a bug. label Jan 3, 2023
@abayer abayer added this to the Pipelines v0.44 milestone Jan 3, 2023
@abayer abayer self-assigned this Jan 3, 2023
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jan 3, 2023
@abayer
ChildReference status helper functions should support both CustomRuns…
8b90bd7 
… and Runs

fixes tektoncd#5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Jan 3, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Jan 4, 2023
tekton-robot pushed a commit that referenced this issue Jan 4, 2023
@abayer @tekton-robot
ChildReference status helper functions should support both CustomRuns…
1409f71 
… and Runs

fixes #5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this issue Jan 4, 2023
@abayer
ChildReference status helper functions should support both CustomRuns…
333955a 
… and Runs

fixes tektoncd#5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
JeromeJu pushed a commit to JeromeJu/pipeline that referenced this issue Jan 4, 2023
@abayer @JeromeJu
ChildReference status helper functions should support both CustomRuns…
76af1d5 
… and Runs

fixes tektoncd#5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot pushed a commit that referenced this issue Jan 5, 2023
@abayer @tekton-robot
ChildReference status helper functions should support both CustomRuns…
a1bac54 
… and Runs

fixes #5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Pipelines v0.44 (LTS)
1 participant
@abayer