Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP 0075, 0076] More ways of referencing params and results #5056

Closed
ywluogg opened this issue Jun 29, 2022 · 5 comments
Closed

[TEP 0075, 0076] More ways of referencing params and results #5056

ywluogg opened this issue Jun 29, 2022 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ywluogg
Copy link
Contributor

ywluogg commented Jun 29, 2022

Feature request

There are certain ways of referencing params and results, either as a whole or accessing keys, are implemented and tracked in #4723, but there are other ways that should be considered for accessing params and results.

Thanks for @chuangw6 and @Yongxuanzhang 's summary, the following are supported:

  • String Types
    • $(tasks.myTask.results.myStringResult)
    • $(tasks.myTask.results[‘my.String.Result’])
    • $(tasks.myTask.results["my.String.Result"])
  • Array Types
    • $(tasks.myTask.results.myArrayResult[*])
    • $(tasks.myTask.results.myArrayResult[i])
  • Object Types
    • $(tasks.myTask.results.myObjectResult[*])
    • $(tasks.myTask.results.myObjectResult.key1)

Below are few other ways are listed below that are not supported but should be considerred:

  • Array Types
    • $(tasks.myTask.results[‘myArrayResult’][*])
    • $(tasks.myTask.results[“myArrayResult”][*])
    • $(tasks.myTask.results[‘myArrayResult’][i])
    • $(tasks.myTask.results[“myArrayResult”][i])
  • Object Types
    • $(tasks.myTask.results[“my.Object.Result”][*])
    • $(tasks.myTask.results[“my.Object.Result”].key1)
    • $(tasks.myTask.results[“my.Object.Result”][“my.key1”])

Use case

Stated above.

@ywluogg ywluogg added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2022
@chuangw6
Copy link
Member

chuangw6 commented Jun 29, 2022

$(tasks.myTask.results[“my.Object.Result”][*])
$(tasks.myTask.results[“my.Object.Result”].key1)
$(tasks.myTask.results[“my.Object.Result”][“my.key1”])

Object param/result name and its keys shouldn't contain dots. see more details here

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2022
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 3, 2022
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Todo to Done in Tekton Community Roadmap Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Done
Development

No branches or pull requests

3 participants