Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the kaniko tests timeout from 2m #4863

Closed
mattmoor opened this issue May 12, 2022 · 2 comments · Fixed by #4871
Closed

Raise the kaniko tests timeout from 2m #4863

mattmoor opened this issue May 12, 2022 · 2 comments · Fixed by #4871
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flakey test

Comments

@mattmoor
Copy link
Member

Expected Behavior

kaniko tests reliably pass.

Actual Behavior

We frequently see the kaniko tests flake downstream, and most of the ones I've looked at are timeouts.

Quoting @imjasonh "Nobody should expect kaniko to do anything reliably in 2m" 🤣

cc @abayer since this touches on flakes (not sure if you've seen this in your adventures)

@mattmoor mattmoor added the kind/bug Categorizes issue or PR as related to a bug. label May 12, 2022
@afrittoli afrittoli added the kind/flake Categorizes issue or PR as related to a flakey test label May 12, 2022
@afrittoli
Copy link
Member

/cc @lbernick @xchapter7x

abayer added a commit to abayer/tektoncd-pipeline that referenced this issue May 17, 2022
…outs

fixes tektoncd#4863

The parallelism change appears to make a real difference in cutting down on flaky
tests, while only increasing total duration of the integration test runs to ~30-35
minutes from ~25, which seems like a worthy trade to me.

Also bumps the timeout for Kaniko tasks in e2e tests to 5 minutes, where a timeout
was specified in the first place.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer
Copy link
Contributor

abayer commented May 17, 2022

/assign

tekton-robot pushed a commit that referenced this issue May 17, 2022
…outs

fixes #4863

The parallelism change appears to make a real difference in cutting down on flaky
tests, while only increasing total duration of the integration test runs to ~30-35
minutes from ~25, which seems like a worthy trade to me.

Also bumps the timeout for Kaniko tasks in e2e tests to 5 minutes, where a timeout
was specified in the first place.

Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flakey test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants