Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricting tekton.dev labels in metadata #4366

Open
pritidesai opened this issue Nov 9, 2021 · 7 comments
Open

restricting tekton.dev labels in metadata #4366

pritidesai opened this issue Nov 9, 2021 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@pritidesai
Copy link
Member

Tekton resources are automatically assigned certain labels including the ones with tekton.dev. The labels are created and propagated from one resource to another using this group name to signify the association and relationship between pipeline task, taskRun, pipeline, and pipelineRun . We should restrict possibility of overwriting those labels otherwise it could result in conflicting resources.

Result of the discussion in PR #2826.

Opening this issue to track the work done in PR #2891 and possibly implementing the restriction.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2022
@lbernick
Copy link
Member

lbernick commented Feb 7, 2022

/priority backlog

@tekton-robot tekton-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 7, 2022
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2022
@austinzhao-go
Copy link
Contributor

thanks @afrittoli hints out.
TEP-0106 should also be applied with the similar constraints to avoid overwriting the Tekton metadata. marked a follow up action on my side to sync the work from this thread.

@pritidesai pritidesai added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 9, 2022
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@lbernick lbernick added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2022
@lbernick
Copy link
Member

@vdemeester is this closed now as a result of #6441?

@vdemeester
Copy link
Member

@lbernick not really, #6441 was just about the "other projects" labels issues (chains.tekton.dev, …). This issue is more about restricting tekton.dev/* labels / annotations to only be set by us (tektoncd/pipeline controllers) and filtered from outside (aka not allowed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

5 participants