-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design and implement paused Task execution until condition is met #233
Comments
Thanks for writing this up @abayer ! Would you see yourself expressing this at the level of the Pipeline or the Task itself? (I'm thinking Pipeline?) |
Hmm. Good question. As part of the Pipeline reference to the Task does feel logical when I think about it. The Task could be used in multiple Pipelines that may not always all want the constraint. Good catch, thanks! |
@bobcatfish Feels different to me - #27 is "should this Task execute at all" while this is "when should this Task execute". But I could be wrong. |
Makes sense @abayer ! I also updated the description here with some requirements that @demobox shared with me, i.e. that pausing and resuming is really about async execution in general |
Thanks, @bobcatfish! Happy to elaborate on those if useful |
Always @demobox :D :D :D |
hey @abayer @bobcatfish @demobox
Considering this would it be fine to declare "wait until condition" at Could you please shed some light on this? |
Hey, just want to check if we would see this getting implemented anytime soon. |
Is this going to allow a user interaction like in Jenkins Input Step? For example, I would like to run "helmfile diff" task and then manually approve the continuation of the pipeline. The next task would probably be "helmfile sync", but it would be nice to manually review the diffs before approving it. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is in our roadmap /lifecycle frozen |
Expected Behavior
A
Task
can be configured to not commence execution until a condition, such as a particular value being present in theTaskRun
's metadata, is true.Actual Behavior
Task
s always run to completion or failureAdditional Info
This would enable building features like manual approval or automated quality gates in higher-level applications utilizing Build Pipeline, rather than requiring that any specific "wait until X is true before executing this
Task
" functionality be built directly into the CRDs....this is my first attempt at creating an issue here, so feel free to rewrite as needed. =)
The text was updated successfully, but these errors were encountered: