Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build steps that rely on entrypoint wont work properly with logging, i.e. Command is required currently #175

Closed
aaron-prindle opened this issue Oct 22, 2018 · 1 comment · Fixed by #183
Closed

Build steps that rely on entrypoint wont work properly with logging, i.e. Command is required currently #175

aaron-prindle opened this issue Oct 22, 2018 · 1 comment · Fixed by #183
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given
Milestone
(0.3 Alpha releas...

Comments

@aaron-prindle
Copy link
Contributor

Expected Behavior

A BuildStep that uses an in image with an executes normally as it would if ran standalone

Actual Behavior

The entrypoint modification done for the logging will "blowup" the user defined entypoint leaving the container not running correctly

Steps to Reproduce the Problem

  1. Create an image w/ only an "Entrypoint" and no "Command"
  2. Specify that image as a BuildStep
  3. Run the Build
  4. BuildStep will not run as expected

Possible Fix

We can update the controller to inspect the image's Entrypoint and use that if required.
@aaron-prindle aaron-prindle mentioned this issue Oct 22, 2018
Merged
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given labels Oct 22, 2018
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 24, 2018
Load builtin entrypoint while redirecting steps
bf8be01 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.
@tanner-bruce tanner-bruce mentioned this issue Oct 24, 2018
Merged
@tanner-bruce
Copy link

I have PR #183 open with an initial attempt at resolving this.

tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 25, 2018
Load builtin entrypoint while redirecting steps
dfbed84 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 27, 2018
Load builtin entrypoint while redirecting steps
90f82e8 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 29, 2018
Load builtin entrypoint while redirecting steps
f874817 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 31, 2018
@tannerb
Load builtin entrypoint while redirecting steps
7fd99fb 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Oct 31, 2018
@tannerb
Load builtin entrypoint while redirecting steps
c5d7706 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
449dffe 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
6721e8f 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
4159d84 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
3de01a1 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
5bbcd2f 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
2ebd459 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
tanner-bruce pushed a commit to tanner-bruce/build-pipeline that referenced this issue Nov 1, 2018
@tannerb
Load builtin entrypoint while redirecting steps
a40eb0c 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes tektoncd#175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes tektoncd#175
@bobcatfish bobcatfish added this to the 0.0.1 Alpha release milestone Nov 3, 2018
knative-prow-robot pushed a commit that referenced this issue Nov 6, 2018
@tannerb @knative-prow-robot
Load builtin entrypoint while redirecting steps
8fa4437 
Currently, any steps in a Pipeline that rely on the built in entrypoint
of a container will not have the expected behaviour while running due to
the entrypoint being overridden at runtime. This fixes #175.

A major side effect of this work is that the override step will now
possibly make HTTP calls every time a step is overridden. There is very
rudimentary caching in place, however this could likely be improved if
performance becomes an issue.

Fixes #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given
Projects
None yet
Milestone
(0.3 Alpha release) Docs + Output Res...
Development

Successfully merging a pull request may close this issue.

Load entrypoint from remote tanner-bruce/build-pipeline
3 participants
@bobcatfish @aaron-prindle @tanner-bruce