Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce E2E test dependencies on external components #1372

Closed
afrittoli opened this issue Oct 2, 2019 · 12 comments · Fixed by #1415
Closed

Reduce E2E test dependencies on external components #1372

afrittoli opened this issue Oct 2, 2019 · 12 comments · Fixed by #1415
Labels
area/testing Issues or PRs related to testing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@afrittoli
Copy link
Member

afrittoli commented Oct 2, 2019 •
edited
Loading

Expected Behavior

It should be possible to run E2E tests in any k8s cluster with no need for external dependencies. We could use sidecars to run a container registry, a git server, a GCS like service etc.

Actual Behavior

The kaniko test expects a container registry to push images to, which requires credentials.
The GCS tests expects to push to a bucket on GCS, which requires credentials.
This makes it rather complex to setup an environment for E2E tests, which goes in the way of people running the integration tests in their own k8s cluster.
@afrittoli afrittoli added the area/testing Issues or PRs related to testing label Oct 2, 2019
afrittoli added a commit to afrittoli/pipeline that referenced this issue Oct 10, 2019
@afrittoli
Use a local registry in build-push-kaniko
1fbe544 
This is a first step in making our E2E tests more portable and less
dependent on resources outside of the k8s cluster they run into.

This changes the build-push-kaniko taskrun example.
There is a lot of infra setup required to make sure that the service
account used by test is able to push to a registry. The test script
replaces the image URL in the resource with the content of the
KO_DOCKER_REPO environment variable. If that is a gcr.io url then
the service account must be setup for access to it.

The updated version runs a local registry as a sidecar in the pod.
The task now can push to localhost:5000. The port is not exposed
outside of the pod so there is no risk of interference with other
tests.

Partially fixes tektoncd#1372
@afrittoli afrittoli mentioned this issue Oct 10, 2019
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Oct 11, 2019
@afrittoli @tekton-robot
Use a local registry in build-push-kaniko
cbeddf0 
This is a first step in making our E2E tests more portable and less
dependent on resources outside of the k8s cluster they run into.

This changes the build-push-kaniko taskrun example.
There is a lot of infra setup required to make sure that the service
account used by test is able to push to a registry. The test script
replaces the image URL in the resource with the content of the
KO_DOCKER_REPO environment variable. If that is a gcr.io url then
the service account must be setup for access to it.

The updated version runs a local registry as a sidecar in the pod.
The task now can push to localhost:5000. The port is not exposed
outside of the pod so there is no risk of interference with other
tests.

Partially fixes #1372
@afrittoli afrittoli reopened this Oct 11, 2019
@bobcatfish bobcatfish mentioned this issue Nov 25, 2019
Closed
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 23, 2020
@thomaschandler
Run CI YAML Example tests using go test
7319df4 
- Accurately report specific example failures
- Test failures now use same output format as other tests
- Provides greater control over parallelism using args to `go test`
- Use the same test harness as other integration tests
  - De-dupe harness between bash/go

Future work:

  - allow e2e tests to be run entirely locally by expanding SubEnv
    - (avoid external deps, see tektoncd#1372)

Side effects:

  - new `yaml` build tag added so that existing integration tests aren't
    affected
  - Limited to 4 folders for testing
  - no-ci isn't explicitly excluded
  - no recursion in examples directory when finding examples to run

Fixes tektoncd#1251
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 23, 2020
@thomaschandler
Run CI YAML Example tests using go test
629b6a0 
- Accurately report specific example failures
- Test failures now use same output format as other tests
- Provides greater control over parallelism using args to `go test`
- Use the same test harness as other integration tests
  - De-dupe harness between bash/go

Future work:

  - allow e2e tests to be run entirely locally by expanding SubEnv
    - (avoid external deps, see tektoncd#1372)

Side effects:

  - new `yaml` build tag added so that existing integration tests aren't
    affected
  - Limited to 4 folders for testing
  - no-ci isn't explicitly excluded
  - no recursion in examples directory when finding examples to run

Fixes tektoncd#1251
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 23, 2020
@thomaschandler
Run CI YAML Example tests using go test
e80429b 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run entirely
locally by avoiding external deps, see tektoncd#1372
@thomaschandler thomaschandler mentioned this issue May 23, 2020
Merged
3 tasks
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 24, 2020
@thomaschandler
Run CI YAML Example tests using go test
3b9dfd7 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run entirely
locally by avoiding external deps, see tektoncd#1372
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 24, 2020
@thomaschandler
Run CI YAML Example tests using go test
eef02f1 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run entirely
locally by avoiding external deps, see tektoncd#1372. Parallelism may be able to
be increased through more granualar tracking of clustertasks (ie.
cleanup clustertasks per subtest by tracking which tests create them)
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 24, 2020
@thomaschandler
Run CI YAML Example tests using go test
51b1f17 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run entirely
locally by avoiding external deps, see tektoncd#1372. Parallelism may be able to
be increased through more granualar tracking of clustertasks (ie.
cleanup clustertasks per subtest by tracking which tests create them)
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 26, 2020
@thomaschandler
Run CI YAML Example tests using go test
eacb450 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 28, 2020
@thomaschandler
Run CI YAML Example tests using go test
a1f6bb0 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 30, 2020
@thomaschandler
Run CI YAML Example tests using go test
24de76d 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 31, 2020
@thomaschandler
Run CI YAML Example tests using go test
e755117 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue May 31, 2020
@thomaschandler
Run CI YAML Example tests using go test
fbba475 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue Jun 3, 2020
@thomaschandler
Run CI YAML Example tests using go test
9396af5 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue Jun 5, 2020
@thomaschandler
Run CI YAML Example tests using go test
fbad851 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue Jun 5, 2020
@thomaschandler
Run CI YAML Example tests using go test
2f88f79 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue Jun 6, 2020
@thomaschandler
Run CI YAML Example tests using go test
39a0c85 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
thomaschandler added a commit to thomaschandler/pipeline that referenced this issue Jun 7, 2020
@thomaschandler
Run CI YAML Example tests using go test
820f8fe 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes tektoncd#1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see tektoncd#1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
tekton-robot pushed a commit that referenced this issue Jun 22, 2020
@thomaschandler @tekton-robot
Run CI YAML Example tests using go test
4fb1078 
Update to accurately report specific example failures by name. E2E YAML
tests now use same harness and output format as other tests. Fixes #1251

Add a new `yaml` build tag so that existing integration tests aren't
affected. Future updates to SubEnv may allow e2e tests to be run
entirely locally by avoiding external deps, see #1372. NOTE: If an
example creates more than one clustertask, they will not all be cleaned
up.
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 12, 2020
@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot reopened this Aug 13, 2020
@tekton-robot tekton-robot removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2020
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 12, 2021
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a local registry in build-push-kaniko afrittoli/pipeline
3 participants
@vdemeester @afrittoli @tekton-robot