Add log verification to integration tests #119
Milestone
Comments
|
Related issue in knative/build about not being able to access logs: knative/build#232 |
|
An even more related issue in knative/build: knative/build#9 |
knative-prow-robot
pushed a commit
that referenced
this issue
Oct 11, 2018
What is the problem being solved? This pr addresses #119 which explains that the integration tests should support viewing the logs for a Build containers invocation. Why is this the best approach? The solution to get the logs for Builds in this pr relies on using PersistentVolume's. A volume is mounted into the test Build, the BuildSpec container writes to the mounted volume, and then a verfication pod is run that also mounts this Persistent volume at which point the Build logs for the init container that Build spawned are now verifiable. What other approaches did you consider? - Use Stackdriver logs Issues: - Stackdriver can take >30 minutes to propogate logs in some cases so it is not feasible for integration test - Stackdriver use would limit integration tests to only work on clusters with Stackdriver integration What side effects will this approach have? This test will require that all test Tasks that are verifiable only through stdout/logging have to write to disk as that is how we can read out the values for verfification. What future work remains to be done The approach of storing test information in a PersistentVolume is required currently as Kubernetes pod logs are not queryable in some cases one a pod succeeds. If in the future kubernetes better supports these logs natively, we can change this to use the native logging again. Also this should be refactored into an easier to use libray for future tests.
|
Implemented in #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
The integration tests should support viewing the logs for a Build containers invocation (Build -> hello world container -> container logs -> "hello world")
Actual Behavior
Currently we are unable to view the logs for a container that is created by Build as once the container exits, it's logs cannot be queried.
Possible Solutions
sleepin our examples so that we have time to verify that the output we want verified is thereThe text was updated successfully, but these errors were encountered: