Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Hub and Chains CRD as internal objects on Openshift #663

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Adds Hub and Chains CRD as internal objects on Openshift #663

merged 1 commit into from
Mar 8, 2022

Conversation

PuneetPunamiya
Copy link
Member

Signed-off-by: Puneet Punamiya [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 8, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@nikhil-thomas
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
savitaashture
savitaashture reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉

@savitaashture
Copy link
Contributor

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
@savitaashture
Copy link
Contributor

savitaashture commented Mar 8, 2022 •
edited
Loading

/hold

Added hold because component version data https://github.com/tektoncd/operator/blob/main/operatorhub/openshift/manifests/bases/openshift-pipelines-operator-rh.clusterserviceversion.template.yaml#L195-L197 is outdated
Shall we add changes as part of this or separate PR ?

@savitaashture
Copy link
Contributor

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
pradeepitm12
pradeepitm12 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-operator-integration-tests

@PuneetPunamiya
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 1d5cba3 into tektoncd:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@nikhil-thomas nikhil-thomas

@savitaashture savitaashture

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PuneetPunamiya @piyush-garg @nikhil-thomas @savitaashture @tekton-robot @pradeepitm12