Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/cluster tasks #655

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Update/cluster tasks #655

merged 5 commits into from
Mar 8, 2022

Conversation

nikhil-thomas
Copy link
Member

@nikhil-thomas nikhil-thomas commented Mar 4, 2022 •
edited
Loading

Main Changes

  • move tasks from openshift/pipelines-catalog into openshift/kodata/../../source-local

    • remove openshift/pipelines-catalog tasks from fetch task mechanism

  • use the fetch task script only to fetch task from tektoncd/catalog

  • use the fetch task script only to download the task into openshift/kodata/../../source-external (downloaded when along with other payload fetch)

    • the fetch task script does not changte Taks kind to ClusterTask
    • the fetch task script does not create a versioned ClusterTask (task with version in its name

  • operator changes the type of tasks in source-local and source-external from Task to ClusterTask just before installation

  • operator creates versioned versions of ClusterTasks during installation based on version information obtained from environment variable

  • Add image replacement environment variables for clusterTasks in operator controller deployment

    • pinning versions of skopeo-copy, kn images can be done once for each release branch

  • Add a scrpt to find latest sha for latest releases of step images like buildah, s2i, skope-copy and kn

note: all tektoncd/catalog tasks are pulled from main branch. the version subfolder in the catalog organization should ensure the interface remains the same. The content of the tasks downloaded can be freezed per release branch.

Changes

[OpenShift] Improve Addon Task management

Move logic to create 'versioned clustertasks' (clustertasks with version
suffix in names), into operator

Move kind replacement of all tasks into operator

Move tasks from (openshift) pipelines-catalog into operator openshift
kodata

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 4, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 4, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@nikhil-thomas nikhil-thomas marked this pull request as ready for review March 7, 2022 12:32
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@nikhil-thomas
Copy link
Member Author

@piyush-garg @concaf

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@sm43
Copy link
Member

sm43 commented Mar 8, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@nikhil-thomas
Copy link
Member Author

/retest

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 29.6% -3.7

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 12.5% 12.5
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

@nikhil-thomas
Copy link
Member Author

/retest

@nikhil-thomas
Remove non-localy maintained clusterTasks
66bef34 
Remove non-localy maitained clusterTasks from OpenShift ClusterTasks in
kodata

Signed-off-by: Nikhil Thomas <[email protected]>
@nikhil-thomas
Move move locally maintained clustertasks into its own directory
f53f758 
Move locally maintained clustertasks into a `source-local` directorys
within openshift kodata

Signed-off-by: Nikhil Thomas <[email protected]>
@nikhil-thomas
[OpenShift] Improve Addon Task management
ec707c9 
Move logic to create 'versioned clustertasks' (clustertasks with version
suffix in names), into operator

Move kind replacement of all tasks into operator

Move tasks from (openshift) pipelines-catalog into operator openshift
kodata

Modify fetch clustertasks script to download tasks only from
tektoncd/catalog repository main branch

Signed-off-by: Nikhil Thomas <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 18.8% 18.8
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

@nikhil-thomas
Add image replacement script for addon task
c7274cb 
Add a config map to collect image replacement environmnent variables
for openshift platform

Add a script to find latest release tag of a step image, find its sha
and replace it in openshift deploment files

Signed-off-by: Nikhil Thomas <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 18.8% 18.8
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 18.8% 18.8
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

@nikhil-thomas
[openshift] Set 'latest' tag in s2i tasks params
fee6f44 
Set `latest` as the default value for `VERSION` param in `s2i` Tasks

Signed-off-by: Nikhil Thomas <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 18.8% 18.8
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/clustertTask.go 0.0% 18.8% 18.8
pkg/reconciler/openshift/tektonaddon/transformer.go 33.3% 42.6% 9.3

pradeepitm12
pradeepitm12 reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@vdemeester
Copy link
Member

/retest

@nikhil-thomas nikhil-thomas removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 8, 2022
@tekton-robot tekton-robot merged commit abad353 into tektoncd:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@vdemeester vdemeester vdemeester approved these changes

@concaf concaf Awaiting requested review from concaf

Assignees

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhil-thomas @tekton-robot @sm43 @vdemeester @pradeepitm12