Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioned clustertask getting deleted during upgrade #599

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jan 28, 2022

This will fix the issue of versioned clustertask getting
deleted during upgrade
Now two installersets will be created for versioned and
non version clustertask. There is new label getting added
on versioned clustertask installerset having major and minor version
details and the versioned clustertask installetset will only be deleted
when there will be two of same minor and major version and installerset
for latest operator version will be created.
Eventually installerset will remain there of different operator minor version
only ending in versioned clustertask to stay on cluster

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fix versioned clustertask getting deleted during upgrade

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 28, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2022
@piyush-garg piyush-garg force-pushed the fic_1962 branch 2 times, most recently from 03e41b0 to ebd4d1a Compare January 28, 2022 11:57
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2022
This will fix the issue of versioned clustertask getting
deleted during upgrade
Now two installersets will be created for versioned and
non version clustertask. There is new label getting added
on versioned clustertask installerset having major and minor version
details and the versioned clustertask installetset will only be deleted
when there will be two of same minor and major version and installerset
for latest operator version will be created.
Eventually installerset will remain there of different operator minor version
only ending in versioned clustertask to stay on cluster
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@nikhil-thomas
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nikhil-thomas,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants