Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade deadlock in Pipeline and Triggers #592

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Fix upgrade deadlock in Pipeline and Triggers #592

merged 1 commit into from
Jan 28, 2022

Commits on Jan 27, 2022

  1. Fix upgrade deadlock in Pipeline and Triggers 

    Add a mechanism to disable webhook validation if the configMaps
are not already there in the cluster.

What this patch does: when webhook endpoint slice is [], the "rules"
section of config.webhook.** validatingwebhookconfiguration is remove.
So that the updates on configMaps eg: config-defaults are not
deadlocked.

The dead lock is caused due to a cluster level cyclic dependency in
tektoncd/pipelines and in tektoncd/triggers. More details will be captured in
issues in the both repository.

Note: infact this deadlock can occur in any tektoncd project which follows tektoncd/pipeline
file list structure in `config/`.

Signed-off-by: Nikhil Thomas <[email protected]>
    @nikhil-thomas
    nikhil-thomas committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    234fb43 View commit details
    Browse the repository at this point in the history