Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling to generate OperatorHub release artifacts #307

Merged

Conversation

nikhil-thomas
Copy link
Member

@nikhil-thomas nikhil-thomas commented May 19, 2021

Changes

Add tooling to generate OperatorHub release artifacts

Modify resources in config/bases and /config/openshift to make it
work with operator bundle generation tools

Modify kustomization.yaml(s)

Add a csv template for generating release artifacts for Kubernetes

Add first set of generated bundle for kubernetes and openshift platforms

Future Work:

  • write a Tekton Task (like TEP table checker) to ensure that latest version of bundles are pushed with each PR.
  • add this bundle generation tool as a Task in Operator release pipeline.
  • configure bundle generation config.yaml for OpenShift

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 19, 2021
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 19, 2021
@nikhil-thomas nikhil-thomas force-pushed the tools/operatorhub/artifacts branch 2 times, most recently from de6d9f8 to 2166107 Compare May 19, 2021 08:51
@nikhil-thomas
Copy link
Member Author

/retest

@nikhil-thomas nikhil-thomas force-pushed the tools/operatorhub/artifacts branch 3 times, most recently from 8ca9311 to ec5e69c Compare May 27, 2021 13:49
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2021
Makefile Outdated Show resolved Hide resolved
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
@nikhil-thomas nikhil-thomas marked this pull request as ready for review September 1, 2021 12:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2021
@nikhil-thomas nikhil-thomas force-pushed the tools/operatorhub/artifacts branch 2 times, most recently from d02fbb4 to 32edae6 Compare September 1, 2021 13:20
@nikhil-thomas
Copy link
Member Author

/test pull-tekton-operator-integration-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What do we gain by duplicating webhook and operator deployment (between kubernetes and openshift platform) ?
  • Are files in release-artifacts/bundle/{manifests, …} supposed to be in the git index ?

Makefile Show resolved Hide resolved
config/base/kustomization.yaml Show resolved Hide resolved
config/openshift/operator.yaml Show resolved Hide resolved
operatorhub/Makefile Show resolved Hide resolved
operatorhub/kubernetes/README.md Outdated Show resolved Hide resolved
operatorhub/kubernetes/README.md Outdated Show resolved Hide resolved
operatorhub/kubernetes/config.yaml Outdated Show resolved Hide resolved
operatorhub/kubernetes/config.yaml Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2021
nikhil-thomas and others added 8 commits September 3, 2021 18:01
Add bare minimum CSV base

Add Kubernetes OpenShift overlay directories

Signed-off-by: Nikhil Thomas <[email protected]>
Add common fields

Add additional stubs
Add a make target to run `operator-sdk generate bundle` command and
generate updated bundle for tektoncd operator

Add necessary directory structure to organize kustomize bases and overlays

Signed-off-by: Nikhil Thomas <[email protected]>
Add annotations, labels, and other additional metadata

Signed-off-by: Nikhil Thomas <[email protected]>
Modify resources in `config/bases` and `/config/openshift` to make it
work with operator bundle generation tools

Modify `kustomization.yaml`(s)

Add a csv template for generating release artifacts for OpenShift

Signed-off-by: Nikhil Thomas <[email protected]>
Improve the UX of commandline flags of the `bundle.py`

Improve structure of `config.yaml` for bundle.py so that specification
of images and their replace locations is more readable.

Refactor script to make it more readable

Add first set of generated bundle for kubernetes and openshift platforms

Future Work:
- write a Tekton Task (like TEP table checker) to ensure that latest version of bundles are
  pushed with each PR.
- add this bundle generation tool as a Task in Operator release  pipeline.

Signed-off-by: Nikhil Thomas <[email protected]>
Modify webhook deployments manifests to make it work with
csv generation.

Update generate CSVs

Signed-off-by: Nikhil Thomas <[email protected]>
Add a Makefile to run bundle generator tool in operatorhub/tools

Add a script to install `operator-sdk`

Add a first draft of README.md

Signed-off-by: Nikhil Thomas <[email protected]>
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2021
Add a generated bundle for kubernetes platform.

Add docs on the bundle generation tool and on bundle geration for
kubernetes.

Signed-off-by: Nikhil Thomas <[email protected]>
@sm43
Copy link
Member

sm43 commented Sep 6, 2021

lgtm
cc @savitaashture @pradeepitm12

Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants