-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooling to generate OperatorHub release artifacts #307
Add tooling to generate OperatorHub release artifacts #307
Conversation
de6d9f8
to
2166107
Compare
/retest |
8ca9311
to
ec5e69c
Compare
ec5e69c
to
a622fc2
Compare
a622fc2
to
b28a9e3
Compare
b28a9e3
to
85c3a21
Compare
85c3a21
to
dccbe36
Compare
d02fbb4
to
32edae6
Compare
/test pull-tekton-operator-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What do we gain by duplicating webhook and operator deployment (between kubernetes and openshift platform) ?
- Are files in
release-artifacts/bundle/{manifests, …}
supposed to be in the git index ?
operatorhub/kubernetes/manifests/bases/tektoncd-operator.clusterserviceversion.template.yaml
Show resolved
Hide resolved
operatorhub/kubernetes/release-artifacts/bundle/manifests/config-logging_v1_configmap.yaml
Show resolved
Hide resolved
32edae6
to
e0bcb87
Compare
8352b17
to
c8b33ac
Compare
c8b33ac
to
2ad7e92
Compare
Add bare minimum CSV base Add Kubernetes OpenShift overlay directories Signed-off-by: Nikhil Thomas <[email protected]>
Add common fields Add additional stubs
Add a make target to run `operator-sdk generate bundle` command and generate updated bundle for tektoncd operator Add necessary directory structure to organize kustomize bases and overlays Signed-off-by: Nikhil Thomas <[email protected]>
Add annotations, labels, and other additional metadata Signed-off-by: Nikhil Thomas <[email protected]>
Modify resources in `config/bases` and `/config/openshift` to make it work with operator bundle generation tools Modify `kustomization.yaml`(s) Add a csv template for generating release artifacts for OpenShift Signed-off-by: Nikhil Thomas <[email protected]>
Improve the UX of commandline flags of the `bundle.py` Improve structure of `config.yaml` for bundle.py so that specification of images and their replace locations is more readable. Refactor script to make it more readable Add first set of generated bundle for kubernetes and openshift platforms Future Work: - write a Tekton Task (like TEP table checker) to ensure that latest version of bundles are pushed with each PR. - add this bundle generation tool as a Task in Operator release pipeline. Signed-off-by: Nikhil Thomas <[email protected]>
Modify webhook deployments manifests to make it work with csv generation. Update generate CSVs Signed-off-by: Nikhil Thomas <[email protected]>
Add a Makefile to run bundle generator tool in operatorhub/tools Add a script to install `operator-sdk` Add a first draft of README.md Signed-off-by: Nikhil Thomas <[email protected]>
2ad7e92
to
f25f165
Compare
f25f165
to
2a3f377
Compare
Add a generated bundle for kubernetes platform. Add docs on the bundle generation tool and on bundle geration for kubernetes. Signed-off-by: Nikhil Thomas <[email protected]>
2a3f377
to
3bb89e3
Compare
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Add tooling to generate OperatorHub release artifacts
Modify resources in
config/bases
and/config/openshift
to make itwork with operator bundle generation tools
Modify
kustomization.yaml
(s)Add a csv template for generating release artifacts for Kubernetes
Add first set of generated bundle for kubernetes and openshift platforms
Future Work:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes