Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton Results DB_SSLROOTCERT config option #2382

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

enarha
Copy link
Contributor

@enarha enarha commented Oct 28, 2024

Tekton Results provides an option allowing the users to configure DB SSL Root Certificate.

Changes

Tekton Results provides an option allowing the users to configure DB SSL Root Certificate. The option was missing the the operator making the deployment fail when the option is specified.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@jkandasa
Copy link
Member

jkandasa commented Nov 1, 2024

@enarha can you please include user facing documentation for this change?

Tekton Results provides an option allowing the users to configure DB SSL
Root Certificate.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2024
@jkandasa
Copy link
Member

jkandasa commented Nov 4, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@tekton-robot tekton-robot merged commit 92b763e into tektoncd:main Nov 4, 2024
7 of 8 checks passed
@enarha enarha deleted the add-results-db-sslrootcert branch November 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants