Fix chains default config #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
PuneetPunamiya
force-pushed
the
fix--default-chains-config
branch
from
e45ea88
to
86cade7
Compare
tekton-robot
added
size/L
|
The following is the coverage report on the affected files.
|
jkandasa
reviewed
Jul 30, 2024
After making Chains install through TektonConfig, for backward compatibility to keep chains configured data preserved a mechanism was added to add the data from chains-config configMap to TektonConfig But if Chains is installed through TektonConfig and some default chains config, then those were getting over written because chains-config configMap was empty. Hence with this patch removing this support for backward compatibilty Fixes: tektoncd#2160 Signed-off-by: PuneetPunamiya <[email protected]>
PuneetPunamiya
force-pushed
the
fix--default-chains-config
branch
from
86cade7
to
6893d2c
Compare
|
The following is the coverage report on the affected files.
|
jkandasa
approved these changes
Jul 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkandasa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making Chains install through TektonConfig, for backward compatibility to keep chains configured data preserved a mechanism was added to add the data from chains-config configMap to TektonConfig
But if Chains is installed through TektonConfig and some default chains config, then those were getting over written because chains-config configMap was empty.
Hence with this patch removing this support for backward compatibilty
Fixes: #2160
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes