fix: prevent upgrade failures caused by deleting resources

[l-qing]

When installing resources in TektonInstallerSet, if the original resource is in the process of being deleted, it is necessary to wait for the deletion to complete before proceeding with the installation. Otherwise, it may appear that the TektonInstallerSets have been installed successfully, but in the end, there may be missing resources.

In my scenario, when upgrading the pipeline, since the old RoleBinding tekton-pipelines-webhook was still being deleted, the new tektoninstallersets thought the resource already existed with no hash change, so no action was taken. As a result, when the Pod tekton-pipelines-webhook started up, it found that it did not have permissions for certain resources config-logging, leading to startup failure. Its failure directly caused some configmaps config-registry-cert to not be created due to the presence of the validatingwebhookconfigurations named config.webhook.pipeline.tekton.dev. Ultimately, this led to the entire pipeline upgrade failing. Only by reconstructing the instance could recovery be possible.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Run make test lint before submitting a PR
• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

• Bug fixes

fix: prevent upgrade failures caused by deleting resources

[tekton-robot]

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jkandasa]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go	72.5%	73.2%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go	72.5%	73.2%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go	72.5%	73.1%	0.5

[jkandasa]

cc @piyush-garg

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jkandasa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jkandasa]

Thanks for your contribution to tekon operator @l-qing 🎉

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go	72.5%	73.1%	0.5

[piyush-garg]

/lgtm

Thanks for the PR 🎉

[jkandasa]

/retest-required