Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] perform manifest transformation earlier #2083

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jkandasa
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@jkandasa jkandasa added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2024
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 26, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektoninstallerset/client/create.go 77.0% 77.6% 0.5
pkg/reconciler/kubernetes/tektoninstallerset/client/main_set.go 53.1% 52.8% -0.2
pkg/reconciler/kubernetes/tektoninstallerset/client/pre_post_custom_set.go 63.3% 61.1% -2.2
pkg/reconciler/kubernetes/tektoninstallerset/client/update.go 82.7% 83.7% 1.0

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@tekton-robot tekton-robot merged commit 7bc7f7e into tektoncd:main Apr 2, 2024
8 checks passed
@jkandasa jkandasa deleted the options_fix2 branch April 2, 2024 05:04
@jkandasa
Copy link
Member Author

jkandasa commented Apr 2, 2024

/cherry-pick release-v0.70.x

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #2090

In response to this:

/cherry-pick release-v0.70.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"options" adding resource entries on multiple installersets
4 participants