TektonConfig object gets created without any default values

[sm43]

Sometimes, webhook takes time to start and if the controller is started before it
it will create a TektonConfig object
but as webhook is not started the object will not have any default values.

  apiVersion: operator.tekton.dev/v1alpha1
  kind: TektonConfig
  metadata:
    name: config
  spec:
    addon: {}
    pipeline: {}
    profile: all
    pruner: {}
    targetNamespace: tekton-pipelines

[nikhil-thomas]

Oh!. Looks like we need a poll for webhook with retries and timeout in the autocreation logic.

[vdemeester]

On the pipeline controller, we do pass all the object through the default when we fetch them, to make sure they get defaulted, even if they did not get through the validation (old object, …)

[nikhil-thomas]

Thanks @vdemeester

ref: https://github.com/tektoncd/pipeline/blob/8907e408c73480482c618d08eeaaefe0bd4aac68/pkg/reconciler/taskrun/taskrun.go#L270

/good-first-issue

[tekton-robot]

@nikhil-thomas:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Thanks @vdemeester

ref: https://github.com/tektoncd/pipeline/blob/8907e408c73480482c618d08eeaaefe0bd4aac68/pkg/reconciler/taskrun/taskrun.go#L270

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vinamra28]

/assign