Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing profile in TektonConfig doesn't reflect on components #358

Closed
sm43 opened this issue Jul 12, 2021 · 1 comment · Fixed by #394
Closed

Changing profile in TektonConfig doesn't reflect on components #358

sm43 opened this issue Jul 12, 2021 · 1 comment · Fixed by #394
Assignees
@PuneetPunamiya
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sm43
Copy link
Member

sm43 commented Jul 12, 2021

Expected Behavior

changing profile should reflect on components
In case of OpenShift
changing profile from all to basic should delete the tekton addon resource

Actual Behavior

changing profile doesn't have any effect on components.

Steps to Reproduce the Problem

Tested on Openshift but I think would be similar on Kubernetes platform too

  1. Install Operator (by default it will install TektonConfig with all profile)
  2. Change profile to basic in TektonConfig
  3. Addon resource should get deleted but still accessible
@sm43 sm43 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 12, 2021
@PuneetPunamiya
Copy link
Member

/assign

PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Aug 27, 2021
@PuneetPunamiya
Removes the resources based on the profile set
8178dc2 
Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Aug 27, 2021
@PuneetPunamiya
Removes the resources based on the profile set
1fe8ae7 
Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
@PuneetPunamiya PuneetPunamiya mentioned this issue Aug 27, 2021
Merged
3 tasks
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Aug 27, 2021
@PuneetPunamiya
Removes the resources based on the profile set
a7f0080 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Aug 27, 2021
@PuneetPunamiya
Removes the resources based on the profile set
4297958 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Sep 2, 2021
@PuneetPunamiya
Removes the resources based on the profile set
556af31 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Sep 3, 2021
@PuneetPunamiya
Removes the resources based on the profile set
b4eb103 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Sep 3, 2021
@PuneetPunamiya
Removes the resources based on the profile set
f13c6ab 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya added a commit to PuneetPunamiya/operator that referenced this issue Sep 3, 2021
@PuneetPunamiya
Removes the resources based on the profile set
45c4933 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: tektoncd#358

Signed-off-by: Puneet Punamiya <[email protected]>
tekton-robot pushed a commit that referenced this issue Sep 3, 2021
@PuneetPunamiya @tekton-robot
Removes the resources based on the profile set
dcf6156 
This patch includes:

  - When the Tekton Config profile is changed, based on the profile set
    components are deleted

  - For example:

      * If the profile is changed from all to basic:
          * In case of Kubernetes: Dashboard Component is deleted
          * In case of Openshift: Addon Component is deleted

Fixes: #358

Signed-off-by: Puneet Punamiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PuneetPunamiya PuneetPunamiya

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes the resources based on the profile set PuneetPunamiya/operator
2 participants
@PuneetPunamiya @sm43