Updates the Catalog Sync to handle Categories if not present in Hub #286
Conversation
tekton-robot
added
the
size/M
tekton-robot
added
the
approved
|
could you Line 279 in 0ae1afc |
api/pkg/service/catalog/syncer.go
Outdated
| c := model.Category{} | ||
| txn.Model(&model.Category{}).Where(&model.Category{Name: t}).FirstOrCreate(&c) | ||
|
|
||
| err := txn.Model(&model.Category{}).Where(&model.Category{Name: t}).First(&c).Error |
There was a problem hiding this comment.
may be its better to check the categories in lower case 🤔 in where clause
PuneetPunamiya
force-pushed
the
catalog-sync-fix
branch
from
153c05a
to
200680c
Compare
- Initially if there are categories in task which are not
present in Hub, that categories used to get added in
Hub db, this patch handles it by adding a record in
Catalog_Errors table and not adding the categories in DB
Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
catalog-sync-fix
branch
from
200680c
to
e3a44c5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
present in Hub, that categories used to get added in
Hub db, this patch handles it by adding a record in
Catalog_Errors table and not adding the categories in DB
Signed-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.