Fetch installed tekton component version from ConfigMap #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
vinamra28
changed the title
As part of TEP-0041 version of tekton pipelines will be stored in a new ConfigMap and that ConfigMap is given special permissions so that in heavy RBAC enforced environment any user authenticated to the cluster can still fetch the version even if they don't have permissions to view the other resources which are associated with tekton-pipelines. With pipelines 0.25 version this configmap would be available so fetching the version from configmap and if the configmap is not present then it will check for the version present on the label (backward compatible). Signed-off-by: vinamra28 <[email protected]>
vinamra28
force-pushed
the
implement-tep-0041
branch
from
0163e82
to
0753c4d
Compare
|
/meow |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As part of TEP-0041 version of tekton pipelines will be stored in a new
ConfigMap and that ConfigMap is given special permissions so that in
heavy RBAC enforced environment any user authenticated to the cluster
can still fetch the version even if they don't have permissions to view
the other resources which are associated with tekton-pipelines.
With pipelines 0.25 version this configmap would be available so
fetching the version from configmap and if the configmap is not present
then it will check for the version present on the label (backward
compatible).
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.