Add github enterprise support #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
vinamra28
force-pushed
the
add-ghe-support
branch
2 times, most recently
from
28c2bdf
to
bf57dff
Compare
|
/retest |
tekton-robot
added
size/L
sm43
reviewed
Jun 14, 2021
sm43
reviewed
Jun 14, 2021
sm43
requested changes
Jun 14, 2021
sm43
reviewed
Jun 14, 2021
vinamra28
force-pushed
the
add-ghe-support
branch
2 times, most recently
from
c6e713a
to
e87bb75
Compare
vinamra28
force-pushed
the
add-ghe-support
branch
from
e87bb75
to
2b99eb0
Compare
pratap0007
reviewed
Jun 16, 2021
|
/lgtm |
vinamra28
force-pushed
the
add-ghe-support
branch
from
2b99eb0
to
8fe00ce
Compare
|
Thanks for the patch 🤙🏻 |
vinamra28
force-pushed
the
add-ghe-support
branch
from
8fe00ce
to
c664d55
Compare
vinamra28
force-pushed
the
add-ghe-support
branch
5 times, most recently
from
0375ad9
to
1959882
Compare
- Read enterprise url from env and if not provided default to github.com - Configure oauth2 on the basis of github host - Create enterprise client in case of enterprise auth else normal github client - generate raw url of the resource on the basis web url provided - update the deployment manifests Signed-off-by: vinamra28 <[email protected]>
- update the deployment manifests - read enterprise url from env - use `react-ghe-login` in place of `react-github-login` Signed-off-by: vinamra28 <[email protected]>
Signed-off-by: vinamra28 <[email protected]>
vinamra28
force-pushed
the
add-ghe-support
branch
from
1959882
to
547b084
Compare
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
API
UI
react-ghe-loginin place ofreact-github-loginSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.