Updates the Swagger API route #268
Conversation
- This updates the swagger api route by adding a raw url instead of `https:api.hub.tekton.dev` Signed-off-by: Puneet Punamiya <[email protected]>
tekton-robot
added
the
size/XS
| @@ -5,4 +5,4 @@ metadata: | |||
| name: swagger | |||
| namespace: tekton-hub | |||
| data: | |||
| API_URL: 'https://api.hub.tekton.dev' | |||
| API_URL: 'https://raw.githubusercontent.com/tektoncd/hub/main/api/v1/gen/http/openapi3.yaml' | |||
There was a problem hiding this comment.
we should point to a specific commit instead of main branch .. there might be new APIs added and release not done, this will show them in the swagger
There was a problem hiding this comment.
I guess we can keep this as it is over here and at the time of deploying we can make the API_URL to point to the particular tag by setting the env
Line 15 in 6c97d9e
There was a problem hiding this comment.
I think we can use the raw url from the latest release ??
For example https://raw.githubusercontent.com/tektoncd/hub/v1.3.0/api/v1/gen/http/openapi3.yaml
There was a problem hiding this comment.
https://api.hub.tekton.dev this isn't working at the moment so I would avoid keeping it :D
There was a problem hiding this comment.
by default let it point to main branch .. we can update in configmap while deploying
There was a problem hiding this comment.
by default let it point to main branch .. we can update in configmap while deploying
This can even help in development where user can directly see what's there in main
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test pull-tekton-hub-build-tests |
|
/test pull-tekton-hub-build-tests |
a raw url instead of
https:api.hub.tekton.devSigned-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.