API: Updates /categories api to list categories only and removes tags
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
pratap0007
force-pushed
the
update-categories
branch
from
cd658c0
to
55c0dd8
Compare
sm43
reviewed
Jun 1, 2021
api/pkg/db/migration/migration.go
Outdated
| @@ -36,6 +36,8 @@ func Migrate(api *app.APIBase) error { | |||
| addRefreshTokenChecksumColumnInUserTable(log), | |||
| updateCatalogBranchToMain(log), | |||
| addAvatarURLColumnInUsersTable(log), | |||
| removeCatgoryAndTagAssociation(log), | |||
There was a problem hiding this comment.
you can do both in single migration :)
pratap0007
force-pushed
the
update-categories
branch
from
55c0dd8
to
c4bd341
Compare
|
/retest |
1 similar comment
|
/retest |
pratap0007
force-pushed
the
update-categories
branch
from
c4bd341
to
df42890
Compare
sm43
reviewed
Jun 7, 2021
api/pkg/service/category/category.go
Outdated
| log.Error(err) | ||
| return nil, fetchError | ||
|
|
sm43
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pratap0007
force-pushed
the
update-categories
branch
from
df42890
to
611bf10
Compare
tekton-robot
added
the
needs-rebase
Signed-off-by: Shiv Verma <[email protected]>
This commit includes following changes - Modifies category and tag table - Add Migration for tag table to drop category_id column and delete the category-tag constraints - Modifies category parsing logic Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
update-categories
branch
from
611bf10
to
95e2e2c
Compare
tekton-robot
removed
the
needs-rebase
|
Thanks 🤙🏻 /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes following changes
Removes the association between Category and Tag table
and delete the category-tag constraints
Updates
/categoriesapi to list categories only and removes tagsSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.