Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the swagger API by copying it to a custom path #247

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Apr 21, 2021

This fixes the API by copying to a custom path in container while
building the image. Previously, the API used to stop working after
sometime or the file would be missing in container in some cases.
This could be one of the solution to fix it. but the main cause still
has to be fixed.

This will make the API not work locally as the file generated is in gen
and API server will look at the custom path we provided.

Signed-off-by: Shivam Mukhade [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

This fixes the API by copying to a custom path in container while
building the image. Previously, the API used to stop working after
sometime or the file would be missing in container in some cases.
This could be one of the solution to fix it. but the main cause still
has to be fixed.

This will make the API not work locally as the file generated is in gen
and API server will look at the custom path we provided.

Signed-off-by: Shivam Mukhade <[email protected]>
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2021
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2021
@vinamra28
Copy link
Member

/lgtm

@pratap0007
Copy link
Contributor

/lgtm

@PuneetPunamiya
Copy link
Member

/approve
/meow
/woof

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@tekton-robot tekton-robot merged commit 613dc2c into tektoncd:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants