Api to get resources from one or multiple catalogs #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
sm43
reviewed
Mar 23, 2021
pratap0007
force-pushed
the
catalog-resources
branch
from
17dc285
to
6e82354
Compare
tekton-robot
added
size/L
pratap0007
force-pushed
the
catalog-resources
branch
from
6e82354
to
3e806ea
Compare
tekton-robot
removed
the
needs-rebase
|
/retest |
pratap0007
force-pushed
the
catalog-resources
branch
from
3e806ea
to
c59268b
Compare
sm43
reviewed
Mar 31, 2021
tekton-robot
added
the
needs-rebase
pratap0007
force-pushed
the
catalog-resources
branch
from
c59268b
to
4290746
Compare
tekton-robot
removed
the
needs-rebase
|
/retest |
|
@pratap0007 could you please rebase the pr once ?? |
pratap0007
force-pushed
the
catalog-resources
branch
from
4290746
to
a6ecfa2
Compare
|
/lgtm |
This patch adds a catalogs params to query api and which takes one or multiple catalogs name Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
catalog-resources
branch
from
a6ecfa2
to
3b90b54
Compare
|
Thanks 🤙 /lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a catalogs params to query api and
which takes one or multiple catalogs name
endpoint:
/query?catalogs=<catalog_name>&catalogs=<catalog_name>Signed-off-by: Shiv Verma [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.