-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds script to create a release using Tekton #202
Conversation
00bba48
to
e64aa13
Compare
cedb046
to
ce83397
Compare
/retest |
/test pull-tekton-hub-unit-tests |
tekton/api/golang-db-test.yaml
Outdated
- name: POSTGRES_PORT | ||
value: "5432" | ||
sidecars: | ||
- image: postgres:12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we tag the image with digest as well?
tekton/release.sh
Outdated
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.2/git-clone.yaml | ||
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/buildah/0.2/buildah.yaml | ||
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/golangci-lint/0.1/golangci-lint.yaml | ||
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/kubernetes-actions/0.2/kubernetes-actions.yaml | ||
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/npm/0.1/npm.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess bundles are now enabled on dogfooding cluster so maybe we can remove these and directly reference the task via bundles. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be really very nice to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do so we need to make sure that bundles are enabled on pipeline installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep will add in readme
tekton/release.sh
Outdated
|
||
kubectl -n ${HUB_NAMESPACE} create cm ui \ | ||
--from-literal=GH_CLIENT_ID="${GH_CLIENT_ID}" \ | ||
--from-literal=API_URL="https://api.hub.tekton.dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this also like ask from user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that field will have to be updated once API server is deployed ... will change cluster to cluster.
this is for upstream only
Can you please add a readme like the steps to do release and requirements like the cluster with a pipeline installed, what value to the inputs to script, and what they mean? |
98c28cb
to
30fba7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
This adds a bash script to deploy new version of hub on a cluster using Tekton Pipelines. This will create a git tag push it to tektoncd/hub and install and run pipelines for hub which will push images to quay.io/tekton-hub. Signed-off-by: Shivam Mukhade <[email protected]>
/lgtm |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shivam Mukhade [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.