Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds script to create a release using Tekton #202

Merged
merged 1 commit into from
May 17, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Mar 1, 2021

Signed-off-by: Shivam Mukhade [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 1, 2021
tekton/api/pipelinerun.yaml Outdated Show resolved Hide resolved
tekton/ui/pipelinerun.yaml Outdated Show resolved Hide resolved
tekton/ui/pipeline.yaml Outdated Show resolved Hide resolved
tekton/release.sh Outdated Show resolved Hide resolved
Base automatically changed from master to main March 18, 2021 16:08
@sm43 sm43 force-pushed the tekton-ci branch 3 times, most recently from 00bba48 to e64aa13 Compare March 22, 2021 10:08
@sm43 sm43 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@sm43 sm43 force-pushed the tekton-ci branch 2 times, most recently from cedb046 to ce83397 Compare March 30, 2021 09:48
@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@sm43
Copy link
Member Author

sm43 commented Mar 31, 2021

/retest

@sm43 sm43 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@sm43
Copy link
Member Author

sm43 commented Apr 9, 2021

/test pull-tekton-hub-unit-tests

@sm43 sm43 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2021
@tekton-robot tekton-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 9, 2021
- name: POSTGRES_PORT
value: "5432"
sidecars:
- image: postgres:12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we tag the image with digest as well?

Comment on lines 208 to 212
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.2/git-clone.yaml
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/buildah/0.2/buildah.yaml
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/golangci-lint/0.1/golangci-lint.yaml
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/kubernetes-actions/0.2/kubernetes-actions.yaml
kubectl -n ${HUB_CI_NAMESPACE} apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/npm/0.1/npm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess bundles are now enabled on dogfooding cluster so maybe we can remove these and directly reference the task via bundles. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be really very nice to use

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do so we need to make sure that bundles are enabled on pipeline installation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep will add in readme


kubectl -n ${HUB_NAMESPACE} create cm ui \
--from-literal=GH_CLIENT_ID="${GH_CLIENT_ID}" \
--from-literal=API_URL="https://api.hub.tekton.dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this also like ask from user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that field will have to be updated once API server is deployed ... will change cluster to cluster.
this is for upstream only

@piyush-garg
Copy link
Contributor

Can you please add a readme like the steps to do release and requirements like the cluster with a pipeline installed, what value to the inputs to script, and what they mean?

@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@sm43 sm43 force-pushed the tekton-ci branch 2 times, most recently from 98c28cb to 30fba7b Compare May 17, 2021 05:01
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tekton/README.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
This adds a bash script to deploy new version of hub on a cluster
using Tekton Pipelines. This will create a git tag push it to
tektoncd/hub and install and run pipelines for hub which will push
images to quay.io/tekton-hub.

Signed-off-by: Shivam Mukhade <[email protected]>
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@pratap0007
Copy link
Contributor

/approve
/meow

@tekton-robot
Copy link

@pratap0007: cat image

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@tekton-robot tekton-robot merged commit e7688ae into tektoncd:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants