Fixes yamllint and golangci lint errors #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
vdemeester
approved these changes
Feb 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
piyush-garg
reviewed
Feb 24, 2021
sm43
reviewed
Feb 24, 2021
PuneetPunamiya
force-pushed
the
fix-lint
branch
from
68a4972
to
8944baa
Compare
2 tasks
piyush-garg
reviewed
Feb 24, 2021
piyush-garg
reviewed
Feb 24, 2021
PuneetPunamiya
force-pushed
the
fix-lint
branch
2 times, most recently
from
e75c633
to
ac00803
Compare
vinamra28
reviewed
Feb 24, 2021
vinamra28
reviewed
Feb 24, 2021
PuneetPunamiya
force-pushed
the
fix-lint
branch
from
ac00803
to
8f7de67
Compare
Signed-off-by: Puneet Punamiya <[email protected]>
- Adds .yamllint file to set the yaml lint rules - Fixes yamllint errors in config directory Signed-off-by: Puneet Punamiya <[email protected]>
Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
fix-lint
branch
from
8f7de67
to
0b704e1
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.