Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goa.design/plugins and goa.design/goa/v3 to 3.19.0 #1978

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Sep 5, 2024

Bump goa.design/plugins and goa.design/goa/v3 to 3.19.0

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2024
@pratap0007 pratap0007 changed the title Revert "Bumps goa version and updates the gen folder" Revert "Bumps goa version" Sep 9, 2024
@PuneetPunamiya
Copy link
Member

@pratap0007 can you fix the unit test

@pratap0007 pratap0007 changed the title Revert "Bumps goa version" Bump goa.design/plugins and goa.design/goa/v3 to 3.19.0 Sep 11, 2024
@pratap0007
Copy link
Contributor Author

/retest

1 similar comment
@pratap0007
Copy link
Contributor Author

/retest

@PuneetPunamiya
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@tekton-robot tekton-robot merged commit 11c51fd into tektoncd:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants