Adds table in markdown #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
PuneetPunamiya
force-pushed
the
markdown-tables
branch
3 times, most recently
from
df788e9
to
f5c40a9
Compare
vinamra28
reviewed
Jan 21, 2021
PuneetPunamiya
force-pushed
the
markdown-tables
branch
from
f5c40a9
to
f509ee6
Compare
- Previously react-markdown used to not render tables in the markdown correctly, hence `remark-gfm` plugin is used to render the tables. Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
markdown-tables
branch
from
f509ee6
to
548187f
Compare
|
Thanks for the pr |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the markdown correctly, hence
remark-gfmpluginis used to render the tables.
Fixes: #168
Screenshot of the tables not rendered correctly
Screenshot of the tables rendering improved
Signed-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.