Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Adds rating #153

Merged
merged 2 commits into from
Dec 23, 2020
Merged

UI: Adds rating #153

merged 2 commits into from
Dec 23, 2020

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Dec 21, 2020 •
edited
Loading 

This patch adds:
- MST store for rating
- User can rate a particular resource
- User can see their previous rating
- User can update their rating
- To rate a resource user needs to be authenticated to Hub

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 21, 2020
vinamra28
vinamra28 reviewed Dec 21, 2020
View reviewed changes
ui/src/containers/Rating/index.tsx Outdated Show resolved Hide resolved
ui/src/containers/Rating/index.tsx Outdated Show resolved Hide resolved
ui/src/containers/Rating/Rating.test.tsx Outdated Show resolved Hide resolved
PuneetPunamiya
PuneetPunamiya reviewed Dec 22, 2020
View reviewed changes
ui/public/config.js Outdated Show resolved Hide resolved
PuneetPunamiya
PuneetPunamiya reviewed Dec 22, 2020
View reviewed changes
ui/public/config.js Outdated Show resolved Hide resolved
PuneetPunamiya
PuneetPunamiya reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@PuneetPunamiya PuneetPunamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch, the pr looks fine to me only some minor changes to address 🤙

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 22, 2020
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
PuneetPunamiya
PuneetPunamiya reviewed Dec 23, 2020
View reviewed changes
ui/src/store/testdata/rating_resource_13.json Outdated
@@ -0,0 +1 @@
{ "rating": 2 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is a single line data should we add a new file for this or can we just use a constant ?? 🤔 wdyt ?

@vinamra28
Add userRating in store
796f6ad 
- Fetch user rating for a particular resource
- Set the rating value for a particular resource

Signed-off-by: vinamra28 <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@vinamra28
Copy link
Member

/lgtm

PuneetPunamiya
PuneetPunamiya reviewed Dec 23, 2020
View reviewed changes
ui/src/containers/UserProfile/index.tsx Outdated
@@ -18,7 +18,8 @@ const UserProfile: React.FC = () => {
const logout = () => {
localStorage.clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please move this all to store by creating an action ?

@pratap0007
UI:Adds rating
a17a97a 
This patch adds:
- User can rate a particular resource
- User can see their previous rating
- User can update their rating
- To rate a resource user needs to be authenticated to Hub

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@PuneetPunamiya
Copy link
Member

/lgtm
/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2020
@tekton-robot tekton-robot merged commit 77cb573 into tektoncd:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vinamra28 vinamra28

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @vinamra28 @PuneetPunamiya @tekton-robot