Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds readme and yaml on details page #152

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Adds readme and yaml on details page #152

merged 1 commit into from
Dec 21, 2020

Conversation

PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Dec 16, 2020 •
edited
Loading

  • This patch adds:
    • Implementation of readme and yaml on details page by making
      api calls to github using raw url of the resource
    • Renders readme and yaml using react-markdown and syantax-highlighter

Signed-off-by: Puneet Punamiya [email protected]

  • Screenshot of readme of a resource

image

  • Screenshot of yaml of a resource

image

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2020
vinamra28
vinamra28 reviewed Dec 16, 2020
View reviewed changes
ui/src/components/Description/index.tsx Outdated Show resolved Hide resolved
ui/src/components/Description/index.tsx Outdated Show resolved Hide resolved
ui/src/components/Readme/Readme.test.tsx Outdated Show resolved Hide resolved
ui/src/components/Readme/index.tsx Outdated Show resolved Hide resolved
ui/src/components/Yaml/index.tsx Outdated Show resolved Hide resolved
ui/src/components/Yaml/Yaml.test.tsx Outdated Show resolved Hide resolved
ui/src/components/Yaml/Yaml.test.tsx Outdated Show resolved Hide resolved
ui/src/components/Yaml/Yaml.test.tsx Outdated Show resolved Hide resolved
ui/src/components/Readme/Readme.test.tsx Outdated Show resolved Hide resolved
ui/src/containers/Details/Details.test.tsx Outdated Show resolved Hide resolved
@PuneetPunamiya PuneetPunamiya force-pushed the details-page branch 3 times, most recently from 02594cc to 457aa47 Compare December 18, 2020 06:51
vinamra28
vinamra28 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/woof

@tekton-robot
Copy link

@vinamra28: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2020
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2020
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 18, 2020
@PuneetPunamiya
Adds readme and yaml on details page
f213b78 
  - This patch adds:
       - Implementation of readme and yaml on details page by making
         api calls to github using raw url of the resource
       - Renders readme and yaml using `react-markdown` and `syantax-highlighter`

Signed-off-by: Puneet Punamiya <[email protected]>
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2020
vinamra28
vinamra28 reviewed Dec 21, 2020
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
@pratap0007
Copy link
Contributor

/lgtm
/approve
/meow

@tekton-robot
Copy link

@pratap0007: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@tekton-robot tekton-robot merged commit 4f461dc into tektoncd:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratap0007 pratap0007 pratap0007 left review comments

@vinamra28 vinamra28 vinamra28 approved these changes

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vinamra28 vinamra28

@pratap0007 pratap0007

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PuneetPunamiya @tekton-robot @vinamra28 @pratap0007