Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for displaying Run resources #2414

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Related to #1970

  • Add basic list page for Run resources, including pagination, label
    filtering, ability to delete runs (single / batch)
  • Add basic details page for Run resource showing common metadata,
    information about the type of custom task, and the optional params,
    as well as the YAML view showing full details of the resource

In a subsequent set of changes, these pages will be updated to include
additional status and trigger information similar to the recent
TaskRun and PipelineRun design updates.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 17, 2022
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi August 17, 2022 10:03
- Add basic list page for Run resources, including pagination, label
  filtering, ability to delete runs (single / batch)
- Add basic details page for Run resource showing common metadata,
  information about the type of custom task, and the optional params,
  as well as the YAML view showing full details of the resource

In a subsequent set of changes, these pages will be updated to include
additional status and trigger information similar to the recent
TaskRun and PipelineRun design updates.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@tekton-robot tekton-robot merged commit e067152 into tektoncd:main Aug 18, 2022
@AlanGreene AlanGreene deleted the custom_tasks branch August 18, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants