-
Notifications
You must be signed in to change notification settings - Fork 267
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable the Carbon CSS custom properties feature flag so we can more easily handle theming, including component-specific overrides as needed (e.g. log container). Replace some hard-coded background colours with the appropriate theme tokens so they're updated correctly to match the selected theme. Reorganise the SCSS imports so they're no longer loaded from the individual components' JS files. This is for a number of reasons: - support for the CSS custom properties - reduce duplicate styles in output (each JS import of a SCSS file results in a new SASS build context rendering the `import-once` useless) - give consumers more control over the styles loaded Update unit tests to account for Carbon changes in icon-only buttons and dropdowns (they only add title attribute when text is truncated) A future PR will introduce more easily consumable bundles of styles, for example the `PipelineRun` component currently requires the `TaskTree`, `Task`, `Step`, etc. styles to be loaded, so it would make sense to provide an easily consumable SCSS import to fulfill this.
- Loading branch information
1 parent
200e1f9
commit 92c4127
Showing
76 changed files
with
228 additions
and
313 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.