Add more details for param variable replacement as a whole in TEP076 #707
Conversation
tekton-robot
added
the
size/S
|
/assign dibyom |
|
/assign wlynch |
ywluogg
force-pushed
the
fix76
branch
2 times, most recently
from
395dcad
to
aca2223
Compare
tekton-robot
added
size/M
|
This will also be summarized in #4723 |
Co-authored-by: Yongxuan Zhang <[email protected]>
| params: | ||
| - name: environments | ||
| value: | ||
| - '$(tasks.get-environments.results.environments[*])' |
There was a problem hiding this comment.
I can see another benefit of supporting this in array is that we can append several results. But for Object it may not be so helpful? @chuangw6 thinks we shouldn't add support for this
There was a problem hiding this comment.
For array, this variable replacement makes sense to me.
For object, it's different. I'll discuss with you offline.
There was a problem hiding this comment.
Yes. I should've be more clear about this, but since 0076 is all around arrays, so I will only focus on examples for arrays. I will open another PR for 0075 if necessary, once we finalize our discussions in tektoncd/pipeline#4879
There was a problem hiding this comment.
to be clear, this is an alternative approach right?
There was a problem hiding this comment.
FWIW, I'd interpret this syntax as "an array element that holds an array", which is different than the previous 2 examples. Nested arrays are a non-goal for this PR, so perhaps we should omit this?
|
Thank you @ywluogg!! |
| - name: update-all-environments | ||
| params: | ||
| - name: environments | ||
| value: $(tasks.get-environments.results.environments[*]) |
There was a problem hiding this comment.
I think the first two examples are overlapping. We don't need to distinguish whether the variable reference is quoted or not. It's just K8s default behaviour to treat any value as string if it's not array or dictionary no matter if it is quoted (doc). i.e.
params:
- name: environments
value: abcis equivalent to
params:
- name: environments
value: "abc"There was a problem hiding this comment.
I think the first two examples are overlapping. We don't need to distinguish whether the variable reference is quoted or not. It's just K8s default behaviour to treat any value as string if it's not array or dictionary no matter if it is quoted (doc).
I believe that the yaml and json conversions are through K8S API (OpenAPI) and it is generated through swagger.json
And the value field under params is marshaled and unmarshaled by the implemented json.Unmarshaller interface in params_types.go
There was a problem hiding this comment.
Is there a functional difference between how value: foo and value: "foo" is interpreted though? (e.g. they would come in as a string, but we'd recognize the [*] syntax and treat it like an array)
tekton-robot
added
the
kind/tep
| params: | ||
| - name: environments | ||
| value: | ||
| - '$(tasks.get-environments.results.environments[*])' |
There was a problem hiding this comment.
to be clear, this is an alternative approach right?
tekton-robot
added
the
approved
|
API WG - waiting for the approval from @wlynch |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ywluogg is this ok to be merged or are there still open questions? |
Add more details for param variable replacement as a whole in TEP076
When elements in params of type arrays, it should be use variable replacements in three ways