TEP-0059: Skipping Strategies - Migration Plan #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/tep
This was referenced Jul 20, 2021
|
/assign |
|
I assigned myself but didn't get a chance to review and now I'll be out for 2 weeks so taking my name off. |
|
/assign @pritidesai |
ghost
approved these changes
Jul 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
tiny nit: suggest changing the |
This change is a clarification and update to the migration and upgrade plan for skipping strategies. The implementable proposal is to change the scope of `when` expressions to guard the `Task`. This is a backwards-incompatible change. To make the transition smooth, we plan to: - provide a feature flag, `scope-when-expressions-to-task`, which: - will default to `scope-when-expressions-to-task` : "false" to guard a `Task` and its dependent `Tasks` - can be set to `scope-when-expressions-to-task` : "true" to guard a `Task` only - after 9 months, per the [Tekton API compatibility policy](https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md#alpha-beta-and-ga), we'll flip the feature flag and default to ` scope-when-expressions-to-task` : "true" [February 2022] - in the next release, we'll remove the feature flag and `when` expressions will be scoped to guard a `Task` only going forward [March 2022] - when we do [v1 release](tektoncd/pipeline#3548) (projected for early 2022), we will have `when` expressions guarding a `Task` only both in _beta_ and _v1_ We also plan to over-communicate during the migration in Slack, email and working group meetings.
jerop
force-pushed
the
tep-0059-migration
branch
from
8acaee3
to
9537ae7
Compare
|
thanks @jerop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a clarification and update to the migration and upgrade
plan for skipping strategies.
The implementable proposal is to change the scope of
whenexpressionsto guard the
Task. This is a backwards-incompatible change. To make thetransition smooth, we plan to:
scope-when-expressions-to-task, which:scope-when-expressions-to-task: "false" to guarda
Taskand its dependentTasksscope-when-expressions-to-task: "true" to guard aTaskonlywe'll flip the feature flag and default to
scope-when-expressions-to-task: "true" [February 2022]whenexpressionswill be scoped to guard a
Taskonly going forward [March 2022](projected for early 2022), we will have
whenexpressions guarding aTaskonly both in beta and v1We also plan to over-communicate during the migration in Slack, email
and working group meetings.
/cc @tektoncd/core-maintainers
/kind tep