TEP-0007: Conditions Beta Skipping - WhenSkipped #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/tep
jerop
force-pushed
the
when-skipped
branch
2 times, most recently
from
85b385a
to
c10e28b
Compare
jerop
changed the title
|
/cc @skaegi (thought you may be interested) |
Previously, we'd proposed to adding `continueAfterSkip` field which defaults to false and can be set to true to execute ordering-dependent tasks We want to update that proposal because: - using string aliases instead of booleans is preferable because, as described in the Kubernetes API policy, "Think twice about bool fields. Many ideas start as boolean but eventually trend towards a small set of mutually exclusive options. Plan for future expansions by describing the policy options explicitly as a string type alias" - that naming was misleading So, we propose using a `whenSkipped` field which defaults to `skipBranch` and users can set to `runBranch` to execute its branch that's made up of ordering-dependent tasks only Further discussed in tektoncd/pipeline#3176
|
Gonna give it an approve: /approve But leave it to @pritidesai and others to lgtm - also if anyone has different naming ideas for these vals please share!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
yup looks good, thanks @jerop |
jerop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd proposed to adding
continueAfterSkipfield whichdefaults to false and can be set to true to execute ordering-dependent
tasks
We want to update that proposal because:
as described in the Kubernetes API policy, "Think twice about bool
fields. Many ideas start as boolean but eventually trend towards a
small set of mutually exclusive options. Plan for future expansions by
describing the policy options explicitly as a string type alias."
So, we propose using a
whenSkippedfield which defaults toskipBranchand users can set to
runBranchto execute its branch that's made up ofordering-dependent tasks only
Further discussed in tektoncd/pipeline#3176
/cc @pritidesai @bobcatfish
/kind tep